<html>
<head><meta charset="utf-8"><title>I-prioritize #78471 Code bloat from RawVec::grow_amortized · t-compiler/wg-prioritization/alerts · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/index.html">t-compiler/wg-prioritization/alerts</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378471.20Code.20bloat.20from.20RawVec.3A.3Agrow_amortized.html">I-prioritize #78471 Code bloat from RawVec::grow_amortized</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="214822550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378471%20Code%20bloat%20from%20RawVec%3A%3Agrow_amortized/near/214822550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378471.20Code.20bloat.20from.20RawVec.3A.3Agrow_amortized.html#214822550">(Oct 28 2020 at 11:19)</a>:</h4>
<p><span class="user-group-mention" data-user-group-id="3111">@WG-prioritization/alerts</span> issue <a href="https://github.com/rust-lang/rust/issues/78471">#78471</a> has been requested for prioritization.</p>
<h1><a href="https://forge.rust-lang.org/compiler/prioritization/procedure.html#assign-priority-to-unprioritized-issues-with-i-prioritize-label">Procedure</a></h1>
<ul>
<li>Priority?</li>
<li>Regression?</li>
<li>Notify people/groups?</li>
<li>Needs <code>I-nominated</code>?</li>
</ul>



<a name="214822754"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378471%20Code%20bloat%20from%20RawVec%3A%3Agrow_amortized/near/214822754" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Hameer Abbasi <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378471.20Code.20bloat.20from.20RawVec.3A.3Agrow_amortized.html#214822754">(Oct 28 2020 at 11:21)</a>:</h4>
<p>This might be controversial, but I think <code>Vec::push</code> <strong>should</strong> be inlined. So <code>P-low</code>.</p>



<a name="214826219"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378471%20Code%20bloat%20from%20RawVec%3A%3Agrow_amortized/near/214826219" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378471.20Code.20bloat.20from.20RawVec.3A.3Agrow_amortized.html#214826219">(Oct 28 2020 at 12:00)</a>:</h4>
<p>I went through the linked PR <a href="https://github.com/rust-lang/rust/issues/72227">#72227</a> and it seems the discussion focuses on the best tradeoff for performace and memory usage without mentioning the final binary size, so I guess the final binary size is "collateral damage" I'm not sure it can be avoided, to my (little) understanding.</p>
<p>By the way, I looked  "non PGO Firefox builds" up. They are "non Profile-Guided Builds":<br>
<a href="https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Building_with_Profile-Guided_Optimization">https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Building_with_Profile-Guided_Optimization</a></p>



<a name="214826240"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378471%20Code%20bloat%20from%20RawVec%3A%3Agrow_amortized/near/214826240" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378471.20Code.20bloat.20from.20RawVec.3A.3Agrow_amortized.html#214826240">(Oct 28 2020 at 12:00)</a>:</h4>
<p>So yeah long story short <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span>  I'd agree with <code>P-low</code></p>



<a name="214828448"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378471%20Code%20bloat%20from%20RawVec%3A%3Agrow_amortized/near/214828448" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378471.20Code.20bloat.20from.20RawVec.3A.3Agrow_amortized.html#214828448">(Oct 28 2020 at 12:24)</a>:</h4>
<p><code>Vec::Push</code> should be inlined, but we may not want to inline <code>grow_amortized</code> into <code>Vec</code> push. I still think that this is <code>P-low</code>, though I would also be fine with <code>P-medium</code> here</p>



<a name="214882797"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378471%20Code%20bloat%20from%20RawVec%3A%3Agrow_amortized/near/214882797" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378471.20Code.20bloat.20from.20RawVec.3A.3Agrow_amortized.html#214882797">(Oct 28 2020 at 18:58)</a>:</h4>
<p>Issue <a href="https://github.com/rust-lang/rust/issues/78471">#78471</a>'s prioritization request has been removed.</p>



<a name="214882834"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378471%20Code%20bloat%20from%20RawVec%3A%3Agrow_amortized/near/214882834" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378471.20Code.20bloat.20from.20RawVec.3A.3Agrow_amortized.html#214882834">(Oct 28 2020 at 18:58)</a>:</h4>
<p>went with <code>P-medium</code> prefer to go with the highest possible prios :)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>